Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(workflows/test): force color #13801

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Conversation

hasezoey
Copy link
Collaborator

@hasezoey hasezoey commented Sep 1, 2023

Summary

This PR forces color for CI test output, which should make it easier to parse if there are problems (especially for something like debugging #13764)

Color is not enabled by default in github CI because (from what i can tell) it is detected as "not a tty"

Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we add this to the other workflows as well? (Linting, type-checking, etc.)

@hasezoey
Copy link
Collaborator Author

hasezoey commented Sep 1, 2023

(Linting, type-checking, etc.)

i am unsure, do they support it? (do they use supports-color package?)

@Uzlopak
Copy link
Collaborator

Uzlopak commented Sep 1, 2023

image

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vkarpov15 vkarpov15 added this to the 7.5.1 milestone Sep 4, 2023
@vkarpov15 vkarpov15 merged commit 38e5080 into Automattic:master Sep 4, 2023
20 checks passed
@hasezoey hasezoey deleted the testCIColor branch September 4, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants