Issue14204 #14212
Closed
Issue14204 #14212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #14204 unnecessary types removed from QueryOptions interface in query.d.ts
vkarpov15
reviewed
Jan 2, 2024
| @@ -0,0 +1,14 @@ | |||
| import * as mongoose from "mongoose"; | |||
There was a problem hiding this comment.
These changes are irrelevant and unnecessary
| @@ -99,82 +99,10 @@ declare module 'mongoose' { | |||
| PopulateOption, | |||
| SessionOption { | |||
| arrayFilters?: { [key: string]: any }[]; | |||
| batchSize?: number; | |||
There was a problem hiding this comment.
What makes you think that deleting all the query options that operations other than updateOne() use is a valid solution?
| @@ -0,0 +1,46 @@ | |||
| const mongoose = require('mongoose'); | |||
There was a problem hiding this comment.
This isn't relevant to the issue at hand, please delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Examples