perf(document): add fast path for applying non-nested virtuals to JSON #14543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #14394
Summary
#14394 points out that
toObject()
gets slow when there's a lot of virtuals. Part of that is we always take the "slow path" when applying virtuals by assuming the virtual is nested.Consider the following script, 200 documents with 800 virtuals each. The below example uses replica set, but not strictly necessary for this example.
Without this change:
With this change:
Nearly 2x faster. We can take a look and see if we can do better, but this PR seems like low hanging fruit.
Examples