Add null
to select
override return type for findOne
#14545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Normally, a
findOne
orfindById
returnsDocType | null
. When usingQuery.prototype.select
, we can provide aRawDocTypeOverride
in order to define the true return type of the projected document. Currently, this makesfindOne
andfind
queries returnRawDocTypeOverride
directly, but in order to be consistent, it should returnRawDocTypeOverride | null
.This is consistent with how you don't currently have to specify the array version for
find
; that method automatically returns the array version ofRawDocTypeOverride
. Therefore,select
onfindOne
should return the nullable version ofRawDocTypeOverride
automatically.Examples