fix(query): apply translateAliases before casting to avoid strictMode error when using aliases #14562
+36
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14521
Summary
The following code errors out with a "n" is not in the schema error because of
upsert
. The issue is that we first cast the query filter, then runtranslateAliases
, which is a 2-fold bug: 1) alias isn't in schema so Mongoose throws strict mode error with "upsert", 2) Mongoose doesn't apply casting to fields where the user specifies the path's alias rather than the path itself.With this PR, translateAliases runs before query casting.
Examples