use the PangoLayout to get baseline #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chearon
force-pushed
the
baseline-fix
branch
from
2c1602c
to
5fd2515
Compare
Instead of getting it via the PangoContext, which seems to be buggy Fixes Automattic#1037
chearon
force-pushed
the
baseline-fix
branch
from
5fd2515
to
f950be3
Compare
|
Tests passing now. macOS users will notice that the baseline now matches the browser. Needs a Windows check (paging @zbjornson) |
zbjornson
approved these changes
Nov 16, 2017
There was a problem hiding this comment.
Great. Every visual test looks good on Windows.
Also makes #1004 irrelevant by fixing the new test that I left failing in #985 (comment).
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #1037, I wasn't able to reproduce it on Linux but the baselines all seem fine at different rotations/scales for me.
I need to fix the measureText tests too, the implementation is summing ink and logical rects so something is wrong there.