Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract Backend class for screen backends with double buffering support #1540

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

piranna
Copy link
Contributor

@piranna piranna commented Mar 21, 2020

Thanks for contributing!

  • Have you updated CHANGELOG.md?

@piranna piranna mentioned this pull request Mar 22, 2020
1 task
@piranna
Copy link
Contributor Author

piranna commented Aug 3, 2020

Can this be reviewed and merged? It only abstracts the creation of screen-based drawing backends allowing to be as basis to draw directly on Linux framebuffer of X11 o Windows GDI or macOS Cocoa, there's no conflicts at all.

Only thing that maybe would have some concerns are the dynamically created objects at https://github.com/Automattic/node-canvas/pull/1540/files#diff-5c8e889223e6698e689baa171f92bcd9R38-R40, but since they are running in their own short-lived thread they will not create a memory leak. Can somebody confirm it, of tell me what could be a better aproach to explicitly destroy them?

@piranna
Copy link
Contributor Author

piranna commented Oct 17, 2020

Code sync'ed with latest master branch and all tests are fixed and passing in all platforms. Can this pull-request be reviewed and merged? :-)

@piranna
Copy link
Contributor Author

piranna commented Sep 23, 2021

Can this pull-request be reviewed and merged? :-)

@piranna piranna mentioned this pull request May 23, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant