Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up putImageData for RGBA canvases #1606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Speed up putImageData for RGBA canvases #1606

wants to merge 1 commit into from

Conversation

zbjornson
Copy link
Collaborator

@zbjornson zbjornson commented Jun 13, 2020 •
edited

Replaces the byte-wise version with both a faster portable version and a specific version for x86/64 (SSE2).

# ops/sec, higher is better
      before   portable      sse2
a=0   19,024     33,935    71,080
a=FF  16,546     13,847    30,995
a=__   7,537      9,175    22,998

@pcordes I know you had work on this from three years ago. Any comments would be welcome. I stuck with SSE2 for now to avoid dispatching.

Ref #909

  • Have you updated CHANGELOG.md?

LinusU
LinusU approved these changes Jun 24, 2020
View reviewed changes
Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

Didn't understand all the code, but looks good 😅

@zbjornson
Copy link
Collaborator Author

(I haven't merged this yet because I found an even faster way but haven't finished implementing it.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zbjornson @LinusU