improve multi-family output in font desc resolver #2062
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug can be understood without considering the changes from #1987. When the user adds multiple TTFs and assigns them the same family name, we send the system families from the TTFs in a comma separated list, but we weren't correctly ordering that system-family list by the best matches on the user-description side. #1987 exposed it because it almost guarantees each file will have a unique system family.
If the user registers fonts like this:
The
font_face_list
will look like this (approximated system descriptions):When the user does this:
We should send this to the OS:
But we were sending this:
fixes #2041