Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement OffscreenCanvas.convertToBlob #2127

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: implement OffscreenCanvas.convertToBlob #2127

wants to merge 1 commit into from

Conversation

jimmywarting
Copy link
Contributor

@jimmywarting jimmywarting commented Oct 5, 2022 •
edited

  • Have you updated CHANGELOG.md?

This new feature would require ppl to use NodeJS v18 but it's not required.
ppl could also polyfill Blob themself it they wanted to use it.

closes #1845

LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes
lib/canvas.js Show resolved Hide resolved
LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes
lib/canvas.js Outdated Show resolved Hide resolved
LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes
lib/canvas.js Outdated Show resolved Hide resolved
LinusU
LinusU reviewed Oct 8, 2022
View reviewed changes
Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! Left som small comments to address

Could you add a line in the changelog file as well?

@jimmywarting
Copy link
Contributor Author

bump

@LinusU
Copy link
Collaborator

LinusU commented Jul 24, 2023

Sorry for the delay on this, could you add a line to the changelog please? 🙏

@jimmywarting
Copy link
Contributor Author

done

LinusU
LinusU approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

@LinusU
Copy link
Collaborator

LinusU commented Jul 24, 2023

(Windows tests are failing, testing rebasing on lastest master)

@jimmywarting
Copy link
Contributor Author

The failed test is unrelated to this PR. maybe this can be merged anyway?

  1) Canvas
       registerFont:
     Error: ENOENT: no such file or directory, lstat 'D:\a\node-canvas\node-canvas\examples\pfennigFont\pfennigMultiByte🚀.ttf'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce blob's
2 participants
@jimmywarting @LinusU