New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prebuilds for ARM64 Macs #2354
base: master
Are you sure you want to change the base?
Add prebuilds for ARM64 Macs #2354
Conversation
d088684
to
3d15abc
Compare
3d15abc
to
6928269
Compare
101e701
to
dad9ae8
Compare
c255f18
to
ac3db9a
Compare
I've temporarily removed the Linux and Windows builds from the workflow in order to reduce the Actions usage on my personal account while testing. The current status here is that I'm hitting an error about |
Hi @jamesbvaughan , it looks like you are building canvas sources that have migrated from EDIT: I submitted a PR for your branch that I think may help jamesbvaughan#1 |
changes to get macos prebuild to pass on arm64 local machine
2fc9d9b
to
886d26b
Compare
Alright, thanks to @adamcin's help, I think this is ready for a real review! Let me know if you'd like me to clean up the git history at all. |
Thanks for submitting this! Two notes:
|
Thanks @zbjornson. I'll hold off on further work here for now. |
Is there any update in having arm64 pre-build binaries? |
@rafaelmaiolla, in my opinion still boils down to bundling the generated native module with the native dependencies. You may have a look to issue #2036 which has a bit more info on why providing pre-built binaries is difficult. Edit: I just saw that executing/loading my bundled version let to a Follow up: With regard to #2036 this is indeed a signing problem. Signing all generated/patched binaries ( |
This is an updated attempt at #2245, making use of GitHub's new Apple Silicon runners.
With many Mac-based developers transitioning to Apple Silicon, this addition will have a significant impact on their cumulative
yarn/npm install
time.