Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #384 #734

Closed
wants to merge 0 commits into from
Closed

fix #384 #734

wants to merge 0 commits into from

Conversation

wsw0108
Copy link
Contributor

@wsw0108 wsw0108 commented Mar 11, 2016

can be verified by run:
node examples/fill-evenodd.js

@fuzhenn
Copy link

fuzhenn commented Mar 11, 2016

Great.

This pull request implements even-odd fill rule.

context.fill("evenodd")

ctx.rect(0, 0, 100, 50);
ctx.arc(50, 50, 50, 0, 2 * Math.PI);
ctx.fill('evenodd');
//ctx.fill();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this line

@wsw0108
Copy link
Contributor Author

wsw0108 commented Mar 14, 2016

@LinusU I have update the commit, please check it.

@fuzhenn
Copy link

fuzhenn commented Apr 6, 2016

@LinusU
Not in a hurry, but please take some time to have a look at this PR.
We need the even-odd fill rule feature now.

@wsw0108 wsw0108 closed this May 4, 2016
@LinusU
Copy link
Collaborator

LinusU commented May 4, 2016

@wsw0108 Sorry for the delay, I've had a lot going on lately, do you mind opening the pull request again and I would be happy to merge it 👌

@wsw0108
Copy link
Contributor Author

wsw0108 commented May 8, 2016

@LinusU because the branch that create this PR is gone, I create a new PR #762 .
Please review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants