Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add: Fall back to root VC if no topmostPresented is found #1733

Merged
merged 1 commit into from May 10, 2024

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented May 9, 2024

Re-submission of #1653

To test

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@dangermattic
Copy link
Collaborator

dangermattic commented May 9, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.64. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@bjtitus bjtitus changed the title Fall back to root VC if no topmostPresented is found Re-add: Fall back to root VC if no topmostPresented is found May 10, 2024
@bjtitus bjtitus marked this pull request as ready for review May 10, 2024 02:43
@bjtitus bjtitus requested a review from a team as a code owner May 10, 2024 02:43
@bjtitus bjtitus requested review from leandroalonso and removed request for a team May 10, 2024 02:43
@leandroalonso leandroalonso added this to the 7.64 milestone May 10, 2024
@leandroalonso leandroalonso added the Bug Something isn't working label May 10, 2024
@bjtitus bjtitus merged commit 983730e into trunk May 10, 2024
12 of 17 checks passed
@bjtitus bjtitus deleted the bjtitus/launch-url-handling branch May 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants