Update to Electron 4.0.2 #1172
Merged
Update to Electron 4.0.2 #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
force-pushed
the
update/electron-4
branch
from
4ce05cf
to
94e427b
Compare
Also conflicting with the Focus Mode shortcut (⌘⇧F) here due to a change in the KeyboardEvent. (Now needs an explicit check for shiftKey)
Rendered unnecessary by electron/electron#13992
# Conflicts: # package.json
This reverts commit 90a94e7.
This reverts commit d834229.
mirka
force-pushed
the
update/electron-4
branch
from
8056ea4
to
d91438c
Compare
roundhill
approved these changes
Jan 31, 2019
Thanks, I'll keep an eye out for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #744
Fixes tangential issues related to #1171 #1090
The predictable and immediately apparent issues have been addressed. Smoke tested on Windows, Linux, and Mac.
Known issues
The "Checking for Updates" dialog on Linux is showing a menu bar when it shouldn't. This is a known Electron bug. (electron/electron#15901 and/or electron/electron#16521)
TODO
electron-builder20.33.1 is breaking it. Doesn't seem like a known issue so it might be something on our end, but I reported it to the electron-builder repo. In the meantime I think we can keep using the last working release.