Add/media import improvements #1827
Open
+125
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify expiration message Rename output functions signatures Co-authored-by: Sarosh Aga <sarosh.aga@automattic.com>
Move failureDetailsURL to failureDetails.fileErrorURL
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
* Add new lines after error file URLs * Add note about 7 day downloadability to prompt --------- Co-authored-by: Sarosh Aga <sarosh.aga@automattic.com>
t-wright
reviewed
May 13, 2024
…/vip into add/media-import-improvements
Co-authored-by: Todd Wright <4177859+t-wright@users.noreply.github.com>
* Address error messaging feedback * Remove ellipses with conflicts with URL * Revert v1 flow error messages * Call progress tracker print to show downloading message
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the failure details URL for the import media command.
Pull request checklist
New release checklist
Changelog Description
Media import: Add option to download failure details logs from URL returned in the media import request response body.
Steps to Test
Obs.: This test requires a locall VIP API public up and running.
npm run buildScenario 1:
VIP_PROXY="" API_HOST={ LOCAL_VIP_API_PUBLIC_URL } node ./dist/bin/vip-import-media.js @{ TEST_SITE_ID }.{ ENV_SITE } { MEDIA_TO_BE_IMPORTED_URL }The output should contain a message about the errors and a prompt as:
Scenario 2:
Repeat step 1