Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack loader: prefer Jetpack loaded from customer-code #5497

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

rinatkhaziev
Copy link
Contributor

Description

Previously we required the constant named WPCOM_VIP_JETPACK_LOCAL to signal the want to load from client-mu-plugins. Within the current implementation it's an extra step - because we iterate over the list of fallbacks until we find a Jetpack to load.

Changelog Description

Plugin Updated: Jetpack Loader

You don't need to set WPCOM_VIP_JETPACK_LOCAL constant in order to load Jetpack from client-mu-plugins

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 29.42%. Comparing base (4e19e00) to head (5a4631e).

Files Patch % Lines
jetpack.php 0.00% 3 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5497      +/-   ##
=============================================
+ Coverage      29.40%   29.42%   +0.01%     
  Complexity      4759     4759              
=============================================
  Files            282      282              
  Lines          20580    20568      -12     
=============================================
  Hits            6052     6052              
+ Misses         14528    14516      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…n to test

So that any Jetpack in 'client-mu-plugins' takes precedence
@rinatkhaziev rinatkhaziev marked this pull request as ready for review May 2, 2024 15:38
@rinatkhaziev rinatkhaziev requested a review from a team as a code owner May 2, 2024 15:38
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant