Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip newrelic in local and stop throwing when env vars are missing #124

Merged
merged 5 commits into from Apr 10, 2019

Conversation

elazzabi
Copy link
Member

@elazzabi elazzabi commented Apr 9, 2019

This skip newrelic in local and stops throwing when env vars are missing (replacing with logger.error and skipping initialization)

fix #121
fix #122

Copy link
Member

@mjangda mjangda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor tweaks to the error to fix "New Relic".

Looks good otherwise 👌

__tests__/newrelic.tests.js Show resolved Hide resolved
src/newrelic/index.js Outdated Show resolved Hide resolved
src/newrelic/index.js Outdated Show resolved Hide resolved
src/newrelic/index.js Outdated Show resolved Hide resolved
mjangda
mjangda previously approved these changes Apr 10, 2019
@elazzabi
Copy link
Member Author

Thank you for the fixes @mjangda !

@mjangda mjangda merged commit 1c77eab into master Apr 10, 2019
@mjangda mjangda deleted the fix/newrelic-local branch April 10, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable newrelic on local Do not start newrelic if env vars are missing
2 participants