WooPayment REST: conditional initialization. #8805
Open
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.25 MB ℹ️ View Unchanged
|
|
@RadoslavGeorgiev: I have yet to test the manual update process, but the UI works and the PR is available for early feedback. |
kalessil
changed the title
|
@RadoslavGeorgiev: this PR is ready for review. I'd also ask you to confirm the results of the manual testing - on my end the taken approach works, but I want to avoid "works on my machine" scenario 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8797
Related to woocommerce/woocommerce#47266
Changes proposed in this Pull Request
Initialize REST only in a guaranteed REST context to guarantee the runtime state matches the updated state.
This shall prevent crashes due to rest controllers constructor changes during manual plugin updates.
Testing instructions
npm run build:releaseand manually update the plugin.\WC_REST_Payments_Orders_Controller::__constructand add a new mandatory parameternpm run build:releaseand manually update the plugin.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge