Render ECE buttons #8818
Merged
Render ECE buttons #8818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +10.5 kB (+1%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
rafaelzaleski
requested review from
a team and
cesarcosta99
and removed request for
a team
cesarcosta99
requested changes
May 16, 2024
includes/express-checkout/class-wc-payments-express-checkout-button-handler.php
Outdated
Show resolved
Hide resolved
client/express-checkout/index.js
Outdated
| let paymentRequestType; | ||
|
|
||
| // Track the payment request button click event. | ||
| const trackPaymentRequestButtonClick = ( source ) => { |
There was a problem hiding this comment.
Should we rename this to trackExpressCheckoutButtonClick?
There was a problem hiding this comment.
It's unclear how much of this code will be retained once we start processing payments.
I also plan to refactor these files once I jump into payment processing. I'll assess whether it's easier to delete everything that is currently unused or simply rename everything 🤔
There was a problem hiding this comment.
I've updated some variable names and cleaned up the JavaScript to achieve a near-minimal implementation. I've requested another review.
cesarcosta99
requested changes
May 17, 2024
There was a problem hiding this comment.
Thanks for the latest changes and cleaning things up a bit. I've tested it and everything worked as expected, except for ApplePay which I can't test it. I left one last (and minor 🤏) suggestion before giving the final approval.
Before enabling ECE
- Checkout with GooglePay at the checkout page ✅
- Checkout with GooglePay in the product page ✅
- Checkout with ApplePay
⚠️ - I don't have ApplePay set up, if needed, feel free to ask someone else from the team to test it.
- Checkout with the WooPay button from the checkout page ✅
- Checkout with the WooPay button from the product page ✅
- Ensure the ECE buttons are not rendered when the feature flag is disabled ✅
- Checked product page, shortcode cart, shortcode checkout, cart Block and checkout Block.
After enabling ECE
- Confirm that the ECE buttons are rendering ✅
- Checked product page, shortcode cart, shortcode checkout, cart Block and checkout Block.
- Ensure that the PRB buttons are not rendered ✅
- Checked product page, shortcode cart, shortcode checkout, cart Block and checkout Block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8772
Closes #8825
Changes proposed in this Pull Request
Render the ECE buttons behind a feature flag. The buttons are rendered in:
It also relocates functions that were used by other parts of the application, such as the WooPay button, from
payment-request/utilsto a new high-level utility directory,utils/express-checkout. This move aims to decouple these helpers from any specific express checkout implementation.Testing instructions
Before you enable the feature flag, test the PRB buttons and ensure there are no regressions. Also test the WooPay express checkout button.
npm run wp option update _wcpay_feature_stripe_ece 1npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge