Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

My Sites Misc: Remove problematic "blacklist"/"whitelist" language #43395 #43689

Merged
merged 1 commit into from Jul 7, 2020
Merged

My Sites Misc: Remove problematic "blacklist"/"whitelist" language #43395 #43689

merged 1 commit into from Jul 7, 2020

Conversation

sarayourfriend
Copy link
Contributor

Changes proposed in this Pull Request

  • Remove problematic language from documentation, my-sites/themes and my-sites/marketing

Testing instructions

  • Ensure unit tests pass
  • Ensure search welcome card works as expected

Addresses part of #43395

@sarayourfriend sarayourfriend requested a review from a team as a code owner June 25, 2020 15:30
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/remove-problematic-language-whitelist-blacklist-my-sites-marketing-themes

@sarayourfriend sarayourfriend mentioned this pull request Jun 25, 2020
Closed
21 tasks
@sarayourfriend sarayourfriend added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Type] Enhancement labels Jun 25, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sarayourfriend sarayourfriend force-pushed the update/remove-problematic-language-whitelist-blacklist-my-sites-marketing-themes branch from 24960e7 to ce120b0 Compare June 29, 2020 18:05
flootr
flootr approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@flootr flootr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sarayourfriend sarayourfriend merged commit 8316ae2 into master Jul 7, 2020
@sarayourfriend sarayourfriend deleted the update/remove-problematic-language-whitelist-blacklist-my-sites-marketing-themes branch July 7, 2020 12:56
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flootr flootr flootr approved these changes

@folletto folletto Awaiting requested review from folletto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Remove problematic language
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sarayourfriend @matticbot @flootr