Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] Adds rule one-var and autofixes all related errors #47310

Merged
merged 2 commits into from Nov 11, 2020

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Nov 11, 2020

Changes proposed in this Pull Request

After applying this rule it should be easier to autofix no-var and prefer-const

Testing instructions

  • Ignore code style errors, there will be a ton.
  • This change should be safe, nothing to test. If the test are green it means that the app can be compiled and therefore the autofix didn't include any syntax error.

@scinos scinos requested review from a team as code owners November 11, 2020 09:57
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 11, 2020
@scinos scinos changed the title Add/eslint one var [eslint] Adds rule one-var and autofixes all related errors Nov 11, 2020
@scinos scinos requested a review from a team November 11, 2020 10:42
@scinos scinos self-assigned this Nov 11, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos added the Code Style Changes related to eslint rules label Nov 11, 2020
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely beautiful, thank you!

Let's 🚢 once checks are green before it gets stale again.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D52603-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@scinos scinos merged commit 80f83f1 into master Nov 11, 2020
@scinos scinos deleted the add/eslint-one-var branch November 11, 2020 15:13
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 11, 2020
@p-jackson p-jackson mentioned this pull request Nov 15, 2020
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Changes related to eslint rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants