Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coming Soon: enable in all envs #47401

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Coming Soon: enable in all envs #47401

merged 1 commit into from
Nov 26, 2020

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Nov 13, 2020 •
edited

Changes proposed in this Pull Request

⚠️ The following PRs should be merged before we release:

✅ #47442 (ETK deploy)

Coming soon... no longer coming soon!

The plan is to enable Coming Soon v2 for all new sites in production and elsewhere.

Existing sites, which are either

  1. unlaunched (and therefore in Coming Soon Private mode by default) or
  2. launched and have Coming Soon enabled

will remain in v1 until they launch/toggle out of Coming Soon v1 mode.

Testing instructions

See: #47399

@ramonjd ramonjd added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. DO NOT MERGE Coming Soon labels Nov 13, 2020
@ramonjd ramonjd requested a review from a team November 13, 2020 05:02
@ramonjd ramonjd self-assigned this Nov 13, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/enable-coming-soon-v2-in-all-environments

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

This was referenced Nov 15, 2020
Merged
Closed
p-jackson
p-jackson approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

It does take a few seconds for coming soon to work correctly after AT, e.g. when logged in I see the logged-out CS page for a little bit instead of the front end of my site with the launch banner. But I think that's known and a fine limitation.

Exciting!

@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:10
@ramonjd ramonjd mentioned this pull request Nov 22, 2020
Closed
@ramonjd ramonjd removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 26, 2020
@ramonjd ramonjd merged commit 1d54a18 into trunk Nov 26, 2020
@ramonjd ramonjd deleted the update/enable-coming-soon-v2-in-all-environments branch November 26, 2020 03:28
@ramonjd ramonjd mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-jackson p-jackson p-jackson approved these changes

Assignees

@ramonjd ramonjd

Labels
Coming Soon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ramonjd @matticbot @p-jackson