Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update eslint packages #58272

Merged
merged 1 commit into from Dec 15, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 19, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) >=7.32.0 -> >=8.4.1 age adoption passing confidence
eslint-plugin-inclusive-language ^2.1.1 -> ^2.2.0 age adoption passing confidence

Release Notes

muenzpraeger/eslint-plugin-inclusive-language

v2.2.0

Compare Source


Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team November 19, 2021 05:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 19, 2021
@github-actions
Copy link

github-actions bot commented Nov 19, 2021

@matticbot
Copy link
Contributor

matticbot commented Nov 19, 2021

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~31 bytes removed 📉 [gzipped])

name        parsed_size           gzip_size
entry-main       -108 B  (-0.0%)      -31 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~46 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
comments       +282 B  (+0.0%)     -466 B  (-0.3%)
media          -179 B  (-0.0%)     +512 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@renovate renovate bot changed the title chore(deps): update dependency eslint to >=8.2.0 chore(deps): update eslint packages Nov 19, 2021
@@ -33,6 +33,6 @@
"@babel/core": "^7.16.0",
"@babel/eslint-parser": "^7.16.3",
"@babel/parser": "^7.16.4",
"eslint": ">=7.32.0"
"eslint": ">=8.2.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I wonder why it's not updating eslint everywhere else in the repo
  2. I also wonder why we need >=

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a copy/paste from the peerDependency. Some people like to have an open range for peer dependencies so we don't repeat the errors of react 17, where so many packages declared a peer dep on react@^16 and they took so long to add react@^17 to the mix.

But I don't think we should have those open ranges for devDependencies or regular dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the PR for updating eslint in the rest of the repo: #56894

I have no idea why it open two different PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it didn't consider this to be a major update and then split it out? Possibly because of the version range.

@renovate renovate bot force-pushed the renovate/eslint-packages branch 4 times, most recently from 93f28a0 to 6625d67 Compare December 7, 2021 04:15
@renovate renovate bot force-pushed the renovate/eslint-packages branch 2 times, most recently from c1987a3 to 3656bf8 Compare December 14, 2021 09:04
@noahtallen noahtallen merged commit cb93776 into trunk Dec 15, 2021
@noahtallen noahtallen deleted the renovate/eslint-packages branch December 15, 2021 00:01
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants