Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled Updates: implement multi-site design on single site scheduled updates #90443

Merged
merged 4 commits into from May 10, 2024

Conversation

TimBroddin
Copy link
Contributor

@TimBroddin TimBroddin commented May 8, 2024

Related to #90401

Proposed Changes

Implements the design language of the multi-site design for single site scheduled updates.

CleanShot 2024-05-08 at 15 04 46@2x
CleanShot 2024-05-08 at 15 04 57@2x
CleanShot 2024-05-08 at 15 05 07@2x
CleanShot 2024-05-08 at 15 12 03@2x
CleanShot 2024-05-08 at 15 05 26@2x

Testing Instructions

Try this out on Calypso Live

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@TimBroddin TimBroddin requested a review from a team May 8, 2024 13:08
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2024
@TimBroddin TimBroddin self-assigned this May 8, 2024
@TimBroddin TimBroddin changed the title ScheduledUpdates: implement multi-site design on single site scheduled updates Scheduled Updates: implement multi-site design on single site scheduled updates May 8, 2024
@matticbot
Copy link
Contributor

matticbot commented May 8, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~98 bytes removed 📉 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               -305 B  (-0.0%)      -98 B  (-0.0%)
entry-main                  -305 B  (-0.0%)      -98 B  (-0.0%)
entry-subscriptions         -126 B  (-0.0%)      -30 B  (-0.0%)
entry-login                 -126 B  (-0.0%)      -30 B  (-0.0%)
entry-domains-landing       -126 B  (-0.0%)      -30 B  (-0.0%)
entry-browsehappy           -126 B  (-0.1%)      -30 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~247 bytes removed 📉 [gzipped])

name                             parsed_size           gzip_size
plugins                             -13294 B  (-0.6%)    -3829 B  (-0.6%)
jetpack-cloud-plugin-management      -3926 B  (-0.3%)     -434 B  (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

matticbot commented May 8, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug add/scheduled-updates-redesign on your sandbox.

@JanaMW27
Copy link

JanaMW27 commented May 9, 2024

This looks good to me, minus one mino thing, in Calypso we don't use Recoleta for the headlines. On site specific we should use the non-recoleta typography.
Thannkkkkuuuuuuuuu

@TimBroddin TimBroddin force-pushed the add/scheduled-updates-redesign branch from 2d888a8 to 63dabd3 Compare May 10, 2024 07:35
Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • It feels like the heading in multi-site level is too large now. (compare with other A4A items like /sites) Also the text on multi-site level and site specific level is different. It shows "Update schedules" on mulitsite level and "Scheduled Updates" on site specific level.

Screen Shot 2024-05-10 at 4 13 04 PM

  • Should we align the text on New schedule and Add new schedule too?
  • There's no margin for the save button on the site specific level page now, could we add some margin to it?
    Screen Shot 2024-05-10 at 4 18 12 PM

@TimBroddin
Copy link
Contributor Author

  • It feels like the heading in multi-site level is too large now. (compare with other A4A items like /sites) Also the text on multi-site level and site specific level is different. It shows "Update schedules" on mulitsite level and "Scheduled Updates" on site specific level.

My preference would be to change Update schedules to Scheduled Updates on multisite then. On single-site we already show "Scheduled Updates" in the menu, and it would be a bigger change to update the menus there. Also "Scheduled Updates" does ring a little bit better in my eyes. What do you think @ouikhuan?

Screen Shot 2024-05-10 at 4 13 04 PM

  • Should we align the text on New schedule and Add new schedule too?

I'll change it to New Schedule on single site too.

  • There's no margin for the save button on the site specific level page now, could we add some margin to it?
    Screen Shot 2024-05-10 at 4 18 12 PM

👌

@ouikhuan
Copy link
Contributor

Also "Scheduled Updates" does ring a little bit better in my eyes. What do you think @ouikhuan?

Sounds good, thanks!

@TimBroddin TimBroddin force-pushed the add/scheduled-updates-redesign branch from 74b615b to 0ac44db Compare May 10, 2024 08:52
@TimBroddin TimBroddin requested a review from ouikhuan May 10, 2024 09:15
Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for addressing the feedback!

@TimBroddin TimBroddin merged commit dbdb885 into trunk May 10, 2024
12 checks passed
@TimBroddin TimBroddin deleted the add/scheduled-updates-redesign branch May 10, 2024 10:23
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants