New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scheduled Updates: implement multi-site design on single site scheduled updates #90443
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~98 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~247 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
This looks good to me, minus one mino thing, in Calypso we don't use Recoleta for the headlines. On site specific we should use the non-recoleta typography. |
2d888a8
to
63dabd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- It feels like the heading in multi-site level is too large now. (compare with other A4A items like /sites) Also the text on multi-site level and site specific level is different. It shows "Update schedules" on mulitsite level and "Scheduled Updates" on site specific level.
My preference would be to change Update schedules to Scheduled Updates on multisite then. On single-site we already show "Scheduled Updates" in the menu, and it would be a bigger change to update the menus there. Also "Scheduled Updates" does ring a little bit better in my eyes. What do you think @ouikhuan?
I'll change it to New Schedule on single site too. 👌 |
Sounds good, thanks! |
- Add margin to single site submit button - Rename Add new schedule button
74b615b
to
0ac44db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for addressing the feedback!
Related to #90401
Proposed Changes
Implements the design language of the multi-site design for single site scheduled updates.
Testing Instructions
Try this out on Calypso Live
Pre-merge Checklist