A4A: Fix site list when assigning licenses to match sites from the dashboard

[gogdzl]

Related to https://github.com/Automattic/automattic-for-agencies-dev/issues/465

Proposed Changes

• This PR makes the site list when assigning licenses match the site list from the sites dashboard.
  • Achieves this by changing the sites fetching source to the same endpoint as the sites dashboard uses.
  • Adds server side pagination.
• This PR also adds user feedback for empty results.

Testing Instructions

• Apply D148743-code to your sandbox, and point your hosts file to it
  • This diff adds multisite to the sites endpoint results, and also a new filter called not_multisite to filter out multisites
• Go to Purchases -> Licenses (http://agencies.localhost:3000/purchases/licenses)
• Choose and Unassigned license ( e.g. Boost )
• Click over the Assign link
• Verify that the sites list matches the sites dashboard list
• Verify that the pagination works
• Verify that multisites are filtered out for products not compatible with multisites (e.g. Backup)
• Verify that the search box works
• Verify that there is a a message for empty results
• Verify that the sites dashboard still work ( http://agencies.localhost:3000/sites )

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107998

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107998&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-107998&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~908 bytes added 📈 [gzipped])

name                             parsed_size           gzip_size
a8c-for-agencies-marketplace         +2452 B  (+0.4%)     +852 B  (+0.5%)
jetpack-cloud-agency-sites-v2          +53 B  (+0.0%)      +22 B  (+0.0%)
a8c-for-agencies-sites                 +53 B  (+0.0%)      +22 B  (+0.0%)
a8c-for-agencies-overview              +40 B  (+0.0%)      +20 B  (+0.0%)
plugins                                +13 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-plugin-management        +13 B  (+0.0%)       +8 B  (+0.0%)
jetpack-cloud-overview                 +13 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/a4a/465-sites-assigning-licenses-differ-from-dashboard on your sandbox.

[jkguidaven]

I can confirm this work as expected. Nice work!! 👍

Changes looks good to me.

[gogdzl]

Thanks @jkguidaven, I will wait for the matching diff to be approved before merging!