Upgrade build pipeline and remove n8-make #228
Conversation
| @rm -rfv $(BUILDDIR) | ||
|
|
||
| distclean: | ||
| @rm -rfv node_modules |
There was a problem hiding this comment.
Should distclean run clean too? It seems odd for it to clear node_modules but leave previously built files behind.
| @@ -0,0 +1,13 @@ | |||
| module.exports = { | |||
There was a problem hiding this comment.
I'm wondering if we should use calypso-build for this, to ensure config compatibility. Then again, I expect this will only be used for the standalone bundle, while it exists outside of the monorepo?
There was a problem hiding this comment.
My intent here was to do some cleanups before importing this project to the Calypso monorepo. Then it will use calypso-build. At that time, it won't be a huge upgrade of everything, but just a little change that ideally won't change the build output at all.
| @@ -41,20 +44,23 @@ | |||
| "./build/lib/util/fs.js": "./build/lib/util/fs-browser.js" | |||
| }, | |||
| "dependencies": { | |||
| "babel-runtime": "^6.9.2", | |||
| "@babel/runtime": "^7.4.3", | |||
There was a problem hiding this comment.
Could probably use a few version bumps here and there, since this PR has been open for a while. If you go for Babel 7.5.x, do bear babel/babel#10261 in mind.
|
Any progress here, @jsnajdr? The topic of modernising |
Removes dependency on
n8-makeand upgrades the build tools to latest versions:Babel uses
@wordpress/browserslist-configto determine target browsers and the set of transforms. Missing platform features are polyfilled with CoreJS2, using theuseBuiltIns: entryoption.Runtime helpers are transformed to imports from
@babel/runtime.There is a minimalistic Webpack configuration to create the bundled
wpcom.jsscript that's intended for direct inclusion with a script tag.Makefile doesn't need
n8-makeand is completely self-contained.How to test:
The output should be almost indentical to the previous version. Best tested by linking the package into Calypso and testing there.
Note that I removed the
add-module-exportsBabel transform. That could break some usages that do the import incorrectly:no longer works, because
Meis a property of the default export, not an exported binding.We'll bump the major version when publishing, so the breaking change shouldn't be a problem.