Add gitignore and git init to templates #1247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trgiangdo
added
🖧 Devops
trgiangdo
reviewed
Apr 30, 2024
There was a problem hiding this comment.
Thank you @anunayasri for your contribution.
The PR looks really good to me. I would like to propose 2 additional changes:
- The content of
.gitignoreis fully loaded with usual Python files to be ignored. However, there is no.vscodeand Vscode related file. Furthermore, there are a lot of ignore lines for packages that are not closely related to Taipy, like "Translations", "Scrapy", "pdm", "Sphinx", ... We may need a discussion to decide what go into this file to make it suitable for a simple template. - In
tests/templates/test_default_template.pyandtests/templates/test_scenario_mgt_template.py, we do sometimes test for which files and folders are generated after running thetaipy run ...command. Those tests now should take the new.gitignoreand.gitinto account as well.
|
@trgiangdo Apologies! I was not able to reply to the comment earlier. I made the I will make the changes for the 2nd comment. |
jrobinAV
reviewed
May 13, 2024
There was a problem hiding this comment.
Compared to the official template, you remove a few sections.
I would not remove them to keep the file as standard as possible.
What do you think?
jrobinAV
requested review from
florian-vuillemot
and removed request for
florian-vuillemot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671