Remove hover_text from Indicator

[Satoshi-Sh]

Related Issue

Fixed #1147

Updates

• Added div to the Indicator component to capture mouseOver events.

Screenshot

Reference

I referred to this link

[FredLL-Avaiga]

I'm afraid that a simple div would force display block ...

[FredLL-Avaiga]

I think a span would have less impact of the display ?

[Satoshi-Sh]

I tried with a span and an empy <> but the tooltip doesn't work.

Do you mean a new test needs to be added to Indicator.spec.tsx?

[FredLL-Avaiga]

a simple div like this is not acceptable as it would change the display behavior of the indicator to block: can't put 2 in the same line.
It looks like a tooltip directly on a Mui Slider (as used in indicator) doesn't work because the slider uses the same technique as the tooltip to show it's own different tooltips.
A div with inline display behaves the same as a span ie shows the hover text only below the indicator.
I suppose then that a span is better than nothing but still not great ...
I wonder if we should keep the hover_text all together.
thoughts @FabienLelaquais ?

PS: it looks like the test in Indicator.spec.tsx don't pass anymore ?

[FredLL-Avaiga]

please update your branch
I guess Indicator.spec.tsx needs change ?

[FredLL-Avaiga]

We're having a discussion about this with @FabienLelaquais
We still need to find the right meaning of hover_text for indicator ...
We'll get back here on the beginning of next week

[FredLL-Avaiga]

Hi @Satoshi-Sh
we've had quite a bit of discussion on this with @FabienLelaquais and we came to the conclusion that hover_text doesn't make sense in the context of indicator.
I'm sorry to say that we want to remove it completely.
Are you still willing to perform this task ?

[Satoshi-Sh]

Sure, I can work on the task of removing the hover_text.

[Satoshi-Sh]

I tried to delete the hover_text from the Indicator component. Could you take a look at it? @FredLL-Avaiga

#1147

[FredLL-Avaiga]

Looks good to me
Could you also remove it in the factory.py file ?
and also add it in the viselements.json file so that it overrides the default description which is in shared ?
I suppose you'll also have to check the indicator.spec.tsx ?

[Satoshi-Sh]

and also add it in the viselements.json file so that it overrides the default description which is in shared ?

I'm not sure about this instruction. What kind of description should I add to hover_text for the indicator?

[FredLL-Avaiga]

Something like : TODO not implemented

[Satoshi-Sh]

I just ran npm test src/components/Taipy/Indicator and it passed. Let me know if there is a proper way to test it.

[FredLL-Avaiga]

I just ran npm test src/components/Taipy/Indicator and it passed. Let me know if there is a proper way to test it.

Excellent