fix(workflow): only copies static files if dir exists

Fixes double compile bug on startup of dev server with empty static dir Double compile seems to be result of using glob instead of copying file by file webpack-contrib/copy-webpack-plugin#602 (comment)
Availity · Nov 16, 2021 · fbb482c · fbb482c
1 parent ede2b45
commit fbb482c
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 13 deletions.
diff --git a/packages/workflow/helpers/paths.js b/packages/workflow/helpers/paths.js
@@ -7,5 +7,8 @@ const resolveApp = (relativePath) => path.resolve(appDirectory, relativePath);
 
 module.exports = {
   // TODO: add other common paths
-  appNodeModules: resolveApp('node_modules')
+  project: resolveApp(''),
+  app: resolveApp('project/app'),
+  appNodeModules: resolveApp('node_modules'),
+  appStatic: resolveApp('project/app/static')
 };
diff --git a/packages/workflow/settings/index.js b/packages/workflow/settings/index.js
@@ -14,6 +14,7 @@ const fs = require('fs');
 const yargs = require('yargs');
 const getPort = require('get-port');
 const Joi = require('joi');
+const paths = require('../helpers/paths');
 
 function argv() {
   return yargs.argv;
@@ -43,7 +44,7 @@ const settings = {
   ekkoServerPort: null,
 
   app() {
-    return path.join(this.project(), 'project/app');
+    return paths.app;
   },
 
   include() {
@@ -153,7 +154,7 @@ const settings = {
   },
 
   project() {
-    return process.cwd();
+    return paths.project;
   },
 
   version() {

diff --git a/packages/workflow/webpack.config.js b/packages/workflow/webpack.config.js
@@ -1,3 +1,4 @@
+const fs = require('fs');
 const path = require('path');
 const webpack = require('webpack');
 const { existsSync } = require('fs');
@@ -170,19 +171,24 @@ const plugin = (settings) => {
         baseConfig: {
           extends: 'availity/workflow'
         }
-      }),
+      })
+    ]
+  };
+
+  if (fs.existsSync(paths.appStatic)) {
+    config.plugins.push(
       new CopyWebpackPlugin({
         patterns: [
           {
-            context: `${settings.app()}/static`, // copy from this directory
+            context: paths.appStatic, // copy from this directory
             from: '**/*', // copy all files
             to: 'static', // copy into {output}/static folder
-            noErrorOnMissing: true
+            noErrorOnMissing: false
           }
         ]
       })
-    ]
-  };
+    );
+  }
 
   config.plugins.push(new ReactRefreshWebpackPlugin());
 

diff --git a/packages/workflow/webpack.config.production.js b/packages/workflow/webpack.config.production.js
@@ -7,6 +7,7 @@ const path = require('path');
 const TerserPlugin = require('terser-webpack-plugin');
 const webpack = require('webpack');
 const babelPreset = require('./babel-preset');
+const paths = require('./helpers/paths');
 const resolveModule = require('./helpers/resolve-module');
 const html = require('./html');
 const loaders = require('./loaders');
@@ -259,20 +260,24 @@ const plugin = (settings) => {
 
       new loaders.MiniCssExtractPlugin({
         filename: 'css/[name]-[contenthash:8].chunk.css'
-      }),
+      })
+    ]
+  };
 
+  if (fs.existsSync(paths.appStatic)) {
+    config.plugins.push(
       new CopyWebpackPlugin({
         patterns: [
           {
-            context: `${settings.app()}/static`, // copy from this directory
+            context: paths.appStatic, // copy from this directory
             from: '**/*', // copy all files
             to: 'static', // copy into {output}/static folder
-            noErrorOnMissing: true
+            noErrorOnMissing: false
           }
         ]
       })
-    ]
-  };
+    );
+  }
 
   if (settings.isProduction() && !settings.shouldMimicStaging) {
     config.optimization.minimizer.push(