Fix TextBlock.LineHeight #14669
Merged
Fix TextBlock.LineHeight #14669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the ascent so the text is properly centered
|
You can test this PR using the following package version. |
|
@Gillibald This might fix #10658 although I haven't tested myself. TextBox always worked correctly and TextBlock worked fine with some fonts. |
maxkatz6
approved these changes
Feb 20, 2024
Gillibald
added a commit
to Gillibald/Avalonia
that referenced
this pull request
Feb 28, 2024
…t the ascent so the text is properly centered (AvaloniaUI#14669)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR makes sure text stays centered if the custom LineHeight surpasses the regular LineHeight
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues