infra: migrate to ts project references (#28)

AviVahl · Jun 24, 2020 · f9c1b2d · f9c1b2d
1 parent 3c54196
commit f9c1b2d
Show file tree

Hide file tree

Showing 37 changed files with 236 additions and 208 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -14,7 +14,7 @@
     {
       "files": ["*.ts", "*.tsx"],
       "parserOptions": {
-        "project": "./tsconfig.json"
+        "project": "packages/*/{src,test}/tsconfig.json"
       },
       "extends": [
         "plugin:@typescript-eslint/recommended",

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -11,11 +11,13 @@ jobs:
         node-version: [14, 12, 10]
         os: [ubuntu-latest, windows-latest, macOS-latest]
     steps:
-    - uses: actions/checkout@v2
-    - name: Use Node.js ${{ matrix.node-version }}
-      uses: actions/setup-node@v1
-      with:
-        node-version: ${{ matrix.node-version }}
-    - run: npm i -g yarn@1
-    - run: yarn
-    - run: yarn test
+      - uses: actions/checkout@v2
+      - name: Use Node.js ${{ matrix.node-version }}
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - run: npm i -g yarn@1
+      - run: yarn
+      - run: yarn build
+      - run: yarn lint
+      - run: yarn test
diff --git a/.mocharc.js b/.mocharc.js
diff --git a/package.json b/package.json
@@ -5,12 +5,12 @@
     "packages/*"
   ],
   "scripts": {
-    "clean": "lerna run clean --stream --parallel",
-    "build": "lerna run build --stream",
+    "clean": "rimraf ./packages/*/dist",
+    "build": "tsc --build",
+    "watch": "yarn build -w",
+    "test": "mocha \"./packages/*/dist/**/*.unit.js\" --enable-source-maps",
     "lint": "eslint . -f codeframe",
-    "pretest": "yarn build && yarn lint",
-    "test": "lerna run test --stream --parallel",
-    "prettify": "prettier \"./**/*.{js,ts,tsx,md}\" --write"
+    "prettify": "prettier . --write"
   },
   "devDependencies": {
     "@types/chai": "^4.2.11",
@@ -41,6 +41,12 @@
     "printWidth": 120,
     "singleQuote": true
   },
+  "mocha": {
+    "colors": true,
+    "require": [
+      "@ts-tools/robotrix/dist/test/chai-setup"
+    ]
+  },
   "author": "Avi Vahl <avi.vahl@wix.com>",
   "license": "MIT",
   "private": true

diff --git a/packages/build/bin/ts-build.js b/packages/build/bin/ts-build.js
@@ -0,0 +1,3 @@
+#!/usr/bin/env node
+
+require('../dist/cli');
diff --git a/packages/build/cli.js b/packages/build/cli.js
diff --git a/packages/build/package.json b/packages/build/package.json
@@ -2,15 +2,10 @@
   "name": "@ts-tools/build",
   "version": "1.2.6",
   "description": "CLI for easier building of multi-target TypeScript libraries.",
-  "main": "./cjs/index.js",
-  "types": "./cjs/index.d.ts",
+  "main": "./dist/index.js",
+  "types": "./dist/index.d.ts",
   "bin": {
-    "ts-build": "./cli.js"
-  },
-  "scripts": {
-    "clean": "rimraf ./cjs",
-    "prebuild": "yarn clean",
-    "build": "tsc -p tsconfig.build.json"
+    "ts-build": "./bin/ts-build.js"
   },
   "peerDependencies": {
     "typescript": ">=2.8.0"
@@ -21,9 +16,11 @@
     "commander": "^5.1.0"
   },
   "files": [
-    "cjs",
+    "bin",
+    "dist",
+    "!dist/test",
     "src",
-    "cli.js"
+    "!*/tsconfig.{json,tsbuildinfo}"
   ],
   "author": "Avi Vahl <avi.vahl@wix.com>",
   "license": "MIT",

diff --git a/packages/build/src/tsconfig.json b/packages/build/src/tsconfig.json
@@ -0,0 +1,11 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "../dist"
+  },
+  "references": [
+    {
+      "path": "../../transpile/src/tsconfig.json"
+    }
+  ]
+}
diff --git a/packages/build/tsconfig.build.json b/packages/build/tsconfig.build.json
diff --git a/packages/fixtures/index.ts b/packages/fixtures/index.ts
diff --git a/packages/fixtures/tsconfig.tsc-init.json b/packages/fixtures/tsconfig.tsc-init.json
@@ -4,8 +4,8 @@
 
     /* Basic Options */
     // "incremental": true,                   /* Enable incremental compilation */
-    "target": "es5",                          /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */
-    "module": "commonjs",                     /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */
+    "target": "es5" /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019', 'ES2020', or 'ESNEXT'. */,
+    "module": "commonjs" /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', 'es2020', or 'ESNext'. */,
     // "lib": [],                             /* Specify library files to be included in the compilation. */
     // "allowJs": true,                       /* Allow javascript files to be compiled. */
     // "checkJs": true,                       /* Report errors in .js files. */
@@ -25,7 +25,7 @@
     // "isolatedModules": true,               /* Transpile each file as a separate module (similar to 'ts.transpileModule'). */
 
     /* Strict Type-Checking Options */
-    "strict": true,                           /* Enable all strict type-checking options. */
+    "strict": true /* Enable all strict type-checking options. */,
     // "noImplicitAny": true,                 /* Raise error on expressions and declarations with an implied 'any' type. */
     // "strictNullChecks": true,              /* Enable strict null checks. */
     // "strictFunctionTypes": true,           /* Enable strict checking of function types. */
@@ -48,7 +48,7 @@
     // "typeRoots": [],                       /* List of folders to include type definitions from. */
     // "types": [],                           /* Type declaration files to be included in compilation. */
     // "allowSyntheticDefaultImports": true,  /* Allow default imports from modules with no default export. This does not affect code emit, just typechecking. */
-    "esModuleInterop": true,                  /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */
+    "esModuleInterop": true /* Enables emit interoperability between CommonJS and ES Modules via creation of namespace objects for all imports. Implies 'allowSyntheticDefaultImports'. */,
     // "preserveSymlinks": true,              /* Do not resolve the real path of symlinks. */
     // "allowUmdGlobalAccess": true,          /* Allow accessing UMD globals from modules. */
 
@@ -63,7 +63,7 @@
     // "emitDecoratorMetadata": true,         /* Enables experimental support for emitting type metadata for decorators. */
 
     /* Advanced Options */
-    "skipLibCheck": true,                     /* Skip type checking of declaration files. */
-    "forceConsistentCasingInFileNames": true  /* Disallow inconsistently-cased references to the same file. */
+    "skipLibCheck": true /* Skip type checking of declaration files. */,
+    "forceConsistentCasingInFileNames": true /* Disallow inconsistently-cased references to the same file. */
   }
 }
diff --git a/packages/node/package.json b/packages/node/package.json
@@ -2,14 +2,8 @@
   "name": "@ts-tools/node",
   "version": "1.1.3",
   "description": "TypeScript support for Node.js.",
-  "main": "./cjs/index.js",
-  "types": "./cjs/index.d.ts",
-  "scripts": {
-    "clean": "rimraf ./cjs",
-    "prebuild": "yarn clean",
-    "build": "tsc -p tsconfig.build.json",
-    "test": "mocha \"./test/**/*.unit.ts\""
-  },
+  "main": "./dist/index.js",
+  "types": "./dist/index.d.ts",
   "peerDependencies": {
     "typescript": ">=2.8.0"
   },
@@ -18,8 +12,10 @@
     "source-map-support": "^0.5.19"
   },
   "files": [
-    "cjs",
+    "dist",
+    "!dist/test",
     "src",
+    "!*/tsconfig.{json,tsbuildinfo}",
     "r.js"
   ],
   "author": "Avi Vahl <avi.vahl@wix.com>",

diff --git a/packages/node/r.js b/packages/node/r.js
@@ -1 +1 @@
-require('./cjs/register');
+require('./dist/register');
diff --git a/packages/node/src/tsconfig.json b/packages/node/src/tsconfig.json
@@ -0,0 +1,11 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "../dist"
+  },
+  "references": [
+    {
+      "path": "../../transpile/src/tsconfig.json"
+    }
+  ]
+}
diff --git a/packages/node/test/node-extension.unit.ts b/packages/node/test/node-extension.unit.ts
@@ -1,8 +1,9 @@
 import { expect } from 'chai';
-import { join, sep } from 'path';
+import { join, sep, dirname } from 'path';
 import { platform } from 'os';
 import { spawnSync } from 'child_process';
-import { fixturesRoot } from '@ts-tools/fixtures';
+
+const fixturesRoot = dirname(require.resolve('@ts-tools/fixtures/package.json'));
 
 export function runCommand(command: string): { output: string; exitCode: number } {
   const [execName, ...args] = command.split(' ');

diff --git a/packages/node/test/tsconfig.json b/packages/node/test/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "../dist/test",
+    "types": ["node", "mocha"]
+  },
+  "references": [
+    {
+      "path": "../src/tsconfig.json"
+    }
+  ]
+}
diff --git a/packages/node/tsconfig.build.json b/packages/node/tsconfig.build.json
diff --git a/packages/robotrix/package.json b/packages/robotrix/package.json
@@ -2,24 +2,16 @@
   "name": "@ts-tools/robotrix",
   "version": "1.0.4",
   "description": "Useful TypeScript transpilation transformers.",
-  "main": "./cjs/index.js",
-  "module": "./esm/index.js",
-  "types": "./esm/index.d.ts",
-  "scripts": {
-    "clean": "rimraf ./cjs ./esm",
-    "prebuild": "yarn clean",
-    "build": "yarn build:cjs && yarn build:esm",
-    "build:cjs": "tsc -p tsconfig.build.json --outDir cjs --module commonjs",
-    "build:esm": "tsc -p tsconfig.build.json --outDir esm --module esnext",
-    "test": "mocha -r @ts-tools/node/r -r test/chai-setup.ts \"test/**/*.unit.ts\""
-  },
+  "main": "./dist/index.js",
+  "types": "./dist/index.d.ts",
   "peerDependencies": {
     "typescript": ">=2.8.0"
   },
   "files": [
-    "cjs",
-    "esm",
-    "src"
+    "dist",
+    "!dist/test",
+    "src",
+    "!*/tsconfig.{json,tsbuildinfo}"
   ],
   "sideEffects": false,
   "author": "Avi Vahl <avi.vahl@wix.com>",

diff --git a/packages/robotrix/src/tsconfig.json b/packages/robotrix/src/tsconfig.json
@@ -0,0 +1,6 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "../dist"
+  }
+}
diff --git a/packages/robotrix/test/cjs-to-esm-transformer.unit.ts b/packages/robotrix/test/cjs-to-esm-transformer.unit.ts
@@ -1,6 +1,6 @@
 import ts from 'typescript';
 import { expect } from 'chai';
-import { createCjsToEsmTransformer } from '../src';
+import { createCjsToEsmTransformer } from '@ts-tools/robotrix';
 
 const cjsDef = `let exports = {}, module = { exports }`;
 const cjsEsmExport = `export default module.exports`;

diff --git a/packages/robotrix/test/dead-ifs-transformer.unit.ts b/packages/robotrix/test/dead-ifs-transformer.unit.ts
@@ -1,6 +1,6 @@
 import { expect } from 'chai';
 import ts from 'typescript';
-import { deadIfsTransformer } from '../src';
+import { deadIfsTransformer } from '@ts-tools/robotrix';
 
 describe('DeadIfsTransformer', () => {
   const transformers: ts.CustomTransformers = { before: [deadIfsTransformer] };

diff --git a/packages/robotrix/test/node-env-transformer.unit.ts b/packages/robotrix/test/node-env-transformer.unit.ts
@@ -1,6 +1,6 @@
 import { expect } from 'chai';
 import { transpileModule } from 'typescript';
-import { createNodeEnvTransformer } from '../src';
+import { createNodeEnvTransformer } from '@ts-tools/robotrix';
 
 describe('NodeEnvTransformer', () => {
   it('replaces process.env.[PARAM] using provided dictionary', () => {

diff --git a/packages/robotrix/test/react-dev-transformer.unit.ts b/packages/robotrix/test/react-dev-transformer.unit.ts
@@ -1,6 +1,6 @@
 import { expect } from 'chai';
 import ts from 'typescript';
-import { reactDevTransformer } from '../src';
+import { reactDevTransformer } from '@ts-tools/robotrix';
 
 describe('ReactDevTransformer', () => {
   const transformers: ts.CustomTransformers = { before: [reactDevTransformer] };

diff --git a/packages/robotrix/test/remap-imports-transformer.unit.ts b/packages/robotrix/test/remap-imports-transformer.unit.ts
@@ -1,6 +1,6 @@
 import { expect } from 'chai';
 import ts from 'typescript';
-import { createRemapImportsTransformer } from '../src';
+import { createRemapImportsTransformer } from '@ts-tools/robotrix';
 
 describe('RemapImportsTransformer', () => {
   const compilerOptions: ts.CompilerOptions = { target: ts.ScriptTarget.ES2017 };

diff --git a/packages/robotrix/test/tsconfig.json b/packages/robotrix/test/tsconfig.json
@@ -0,0 +1,12 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "../dist/test",
+    "types": ["node", "mocha"]
+  },
+  "references": [
+    {
+      "path": "../src/tsconfig.json"
+    }
+  ]
+}
diff --git a/packages/robotrix/tsconfig.build.json b/packages/robotrix/tsconfig.build.json
diff --git a/packages/transpile/package.json b/packages/transpile/package.json
@@ -2,19 +2,16 @@
   "name": "@ts-tools/transpile",
   "version": "2.0.0",
   "description": "TypeScript transpilation helpers.",
-  "main": "./cjs/index.js",
-  "types": "./cjs/index.d.ts",
-  "scripts": {
-    "clean": "rimraf ./cjs",
-    "prebuild": "yarn clean",
-    "build": "tsc -p tsconfig.build.json"
-  },
+  "main": "./dist/index.js",
+  "types": "./dist/index.d.ts",
   "peerDependencies": {
     "typescript": ">=2.8.0"
   },
   "files": [
-    "cjs",
-    "src"
+    "dist",
+    "!dist/test",
+    "src",
+    "!*/tsconfig.{json,tsbuildinfo}"
   ],
   "author": "Avi Vahl <avi.vahl@wix.com>",
   "license": "MIT",

diff --git a/packages/transpile/src/tsconfig.json b/packages/transpile/src/tsconfig.json
@@ -0,0 +1,6 @@
+{
+  "extends": "../../../tsconfig.base.json",
+  "compilerOptions": {
+    "outDir": "../dist"
+  }
+}
diff --git a/packages/transpile/tsconfig.build.json b/packages/transpile/tsconfig.build.json