this change addresses issue #74 - Filter, submitted by CSester. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the cause: when a regex filter is provided as an option, the first check is made against the path name, and if the path does not match the regex option, then the callback function is called with no error, and the code is exited without processing any of the files within the folder. this change simply ignores the first iteration through the startCopy function, which is the path name.
bill209
added a commit
to bill209/buildIt
that referenced
this pull request
Jul 26, 2015
added fix to ncp module AvianFlu/ncp#96
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the cause: when a regex filter is provided as an option, the first
check is made against the path name, and if the path does not match the
regex option, then the callback function is called with no error, and
the code is exited without processing any of the files within the
folder.
this change simply ignores the first iteration through the startCopy
function, which is the path name.