Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grid overlay to add tilings #1030

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Avengium
Copy link
Contributor

Description

Hi, I added several types of grid overlay to layer > grid.
The types are:
square rotated 45 degrees,
truncated square tiling,
tetrakis square,
triangular tiling,
trihexagonal tiling and
rhombille tiling with rhombus.
Inspired by these uniform tilings: https://en.wikipedia.org/wiki/List_of_Euclidean_uniform_tilings

Type of change

  • New feature
  • Refactoring / style
  • Documentation update / chore
  • Other (please describe)

Versioning

I didn't change any text on versioning.
The files have the same version, so you can decide the scale of the version and which number do you want to put as version.
If you want to merge this change with another ones to make a version with more changes, you can do that too.
Do as you see fit.

Added square rotated 45 degrees, truncated square tiling, tetrakis square, triangular tiling, trihexagonal tiling and rhombille tiling with rhombus. Inspired by these uniform tilings: https://en.wikipedia.org/wiki/List_of_Euclidean_uniform_tilings
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for afmg ready!

Name Link
🔨 Latest commit 20a9102
🔍 Latest deploy log https://app.netlify.com/sites/afmg/deploys/6615872757ded4000789b835
😎 Deploy Preview https://deploy-preview-1030--afmg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Azgaar
Copy link
Owner

Azgaar commented Dec 23, 2023

Hm, I can understand triangle, but how others can be useful? I don't think anyone is using these other tilings in their games

@Avengium
Copy link
Contributor Author

Hi, i put these tilings on the map to allow people use and see these different tilings.
Is not specifically for games, but to allow them a way to imagine distances, routes between places, connections and proportions in the map and measure under different tiles. I think we should include these grids for these reasons alone, aside games.

These tilings are also used in games, both videogames and board games.

Tetrakis square and truncated square tiling (long list):
https://boardgamegeek.com/geeklist/28732/games-played-alquerque-style-grid

Truncated square:
https://boardgamegeek.com/boardgame/4099/keythedral
https://boardgamegeek.com/boardgame/963/gardens-alhambra
https://boardgamegeek.com/boardgame/3154/nautilus

Triangular tiling:
Colossal citadels (that's the name of the videogame): https://twitter.com/unevendungeon
Sylves (is on itchio too) https://www.boristhebrave.com/docs/sylves/1/
https://boardgamegeek.com/boardgame/16498/inka

Rhombus / rhomboid / rhombille grid:
https://boardgamegeek.com/boardgame/9341/lost-valley
Videogame Q*bert and clones: https://freeqbert.org/
rhombus tiling game (is not regular rhombus): https://github.com/davidquick/rhombus-tiling-visualiser

@Azgaar
Copy link
Owner

Azgaar commented Dec 23, 2023

Yes, it can be used in some abstract games, but I don't really see any real usage for the generated map. We can keep it, but would need to fix issues like that:

image

Also would need to think what does "distance between cells" mean in this context:

image

@Avengium
Copy link
Contributor Author

That finer line in rhombille is made using this code. M 0 10 H 11 M 22 10 H 33.
In a 33x20px rectangle. which means: move to x:0, y:10, draw a horizontal line towards x:11. And for the other line move to x:22, y:10 and draw a horizontal line towards x:33. Maybe the fact that i used H instead of L for these ones makes them have a different (thinner) stroke width.

@Azgaar
Copy link
Owner

Azgaar commented Dec 23, 2023

No, it's the fact that you have a viewport with stroke width not being considered. It should be, as well as bevel

@Azgaar
Copy link
Owner

Azgaar commented Jan 16, 2024

@Avengium, are you going to complete this?

@Avengium
Copy link
Contributor Author

Yeah. I want to continue this. How do I accomplish what I'm missing here?

@Azgaar
Copy link
Owner

Azgaar commented Jan 16, 2024

You need to fix the beforementioned issues

@Avengium
Copy link
Contributor Author

Could you explain to me in a way that helps me why those lines have different thicknesses and how to fix these different issues?

@Azgaar
Copy link
Owner

Azgaar commented Feb 12, 2024

Could you explain to me in a way that helps me why those lines have different thicknesses and how to fix these different issues?

It looks a part of the stroke width is out of the viewbox and getting cut. Also I still don't think this tilling is useful.

The stroke width of:
- Tetrakis square.
- Truncated square.
- Triangle tiling.
- Rhombille tiling.
Now has all the same stroke width.
@Avengium
Copy link
Contributor Author

Fixed stroke width of line in style grid for the added tilings in this request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants