Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test for vwan network connection #201

Merged
merged 16 commits into from Apr 20, 2022
Merged

E2E test for vwan network connection #201

merged 16 commits into from Apr 20, 2022

Conversation

jfaurskov
Copy link
Contributor

@jfaurskov jfaurskov commented Apr 7, 2022 •
edited by jtracey93

Overview/Summary

Include E2E test steps for vWan network connection described in 104479

This PR fixes/adds/changes/removes

  1. Add step to check for changes in the infra-as-code/bicep/modules/vnetPeeringVwan path excluding *.md and *.png files.
  2. Update condition to deploy spoke Vnet if there are changes to infra-as-code/bicep/modules/vnetPeeringVwan
  3. Add step to deploy Vwan Network connection to spoke vnet.
  4. Pin Markdown Link Check to V1.0.13 due to Lots of new failures since release 1.0.14 gaurav-nelson/github-action-markdown-link-check#127

Breaking Changes

N/A

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant ADO items
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 7, 2022
@jfaurskov jfaurskov added do not merge do not merge PRs with this label attached as they are not ready etc. hygiene things related to testing, issue triage etc. and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 7, 2022
@jfaurskov jfaurskov changed the title E2 e test for vw an connection E2e test for vwan network connection Apr 7, 2022
@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 changed the title E2e test for vwan network connection E2E test for vwan network connection Apr 7, 2022
@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added this to In progress in ALZ Bicep Public Project Apr 8, 2022
@jfaurskov
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jtracey93
jtracey93 previously approved these changes Apr 19, 2022
View reviewed changes
@jfaurskov jfaurskov removed the do not merge do not merge PRs with this label attached as they are not ready etc. label Apr 20, 2022
@jtracey93
Copy link
Contributor

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfaurskov jfaurskov merged commit c6a76a0 into Azure:main Apr 20, 2022
ALZ Bicep Public Project automation moved this from In progress to Done Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
hygiene things related to testing, issue triage etc.
Projects
No open projects
ALZ Bicep Public Project
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jfaurskov @jtracey93