Add identityURL to internal apis for CMSI usage #3514
+112
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
added
hold
|
Left a few comments, all other changes seems good for identityURL. |
cadenmarchese
changed the title
cadenmarchese
added
size-small
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
jharrington22,
cblecker,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan and
anshulvermapatel
as code owners
|
I'm adding |
cadenmarchese
force-pushed
the
ARO-6086/cuamsi-api-changes
branch
from
9b77750
to
13aaefc
Compare
kimorris27
reviewed
May 8, 2024
kimorris27
previously approved these changes
May 9, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
s-amann
previously approved these changes
May 16, 2024
niontive
reviewed
May 16, 2024
niontive
reviewed
May 16, 2024
niontive
reviewed
May 16, 2024
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
cadenmarchese
force-pushed
the
ARO-6086/cuamsi-api-changes
branch
from
38b747c
to
aaccab3
Compare
kimorris27
requested changes
May 24, 2024
|
/azp run ci, e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-6086
What this PR does / why we need it:
The cluster doc needs to persist identityURL in order for Cluster MSI (CUAMSI) token refreshing to work. The identityURL is a header that is provided by ARM to the RP and is used for token refreshing purposes. For more info, see the design doc: https://docs.google.com/document/d/1dtgp6B-VYyXUmPsMX9f9MdlAE9sON4OuH1Cw9Ij0mmg/edit that @rajdeep wrote.
Test plan for issue:
API calls should succeed in persisting identityURL header when a put or patch call to RP is made.
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?