Add new makefile targets for go mod verification #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run 'go mod' functions to search for tidy, vendor changes and verify it
Update makefile and one doc file docomentation with the change of go-verify over using vendor and tidy
razo7
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig and
tiguelu
as code owners
|
/azp run ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tiguelu
requested changes
May 6, 2024
| @@ -167,7 +170,7 @@ run-portal: | |||
| go run -ldflags "-X github.com/Azure/ARO-RP/pkg/util/version.GitCommit=$(VERSION)" ./cmd/aro portal | |||
|
|
|||
| build-portal: | |||
| cd portal/v2 && npm install && npm run build | |||
| cd portal/v1 && npm install && npm run build && cd ../v2 && npm install && npm run build | |||
There was a problem hiding this comment.
Can we remove this line? It was deleted as part of PR #3465 that removed portal/v1
There was a problem hiding this comment.
Everything looks good to me, except what @tiguelu already pointed about. Once thats changed. LGTM
mociarain
reviewed
May 7, 2024
| @@ -266,9 +269,22 @@ admin.kubeconfig: | |||
| aks.kubeconfig: | |||
| hack/get-admin-aks-kubeconfig.sh | |||
|
|
|||
| .PHONY: go-tidy | |||
There was a problem hiding this comment.
Why each individual PHONY and not added to the overall PHONY at the bottom of the file?
| @@ -18,6 +18,9 @@ GATEKEEPER_VERSION = v3.10.0 | |||
| GATEKEEPER_IMAGE ?= ${RP_IMAGE_ACR}.azurecr.io/gatekeeper:$(GATEKEEPER_VERSION) | |||
| GOTESTSUM = gotest.tools/gotestsum@v1.11.0 | |||
|
|
|||
| # Golang version go mod tidy compatibility | |||
| GOLANG_VERSION ?= 1.20 | |||
There was a problem hiding this comment.
Should we specify 1.20.12? (Still finding my feet with Go, I have no idea how strict it is with versions)
For reference: #3548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
None. It is a small enhancement. Duplicate of #3492.
What this PR does / why we need it:
Run 'go mod' functions to search for tidy, and vendor package changes and then verify it.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
Yes, in the second commit
How do you know this will function as expected in production?