Update to Electron 9 and Spectron 11 #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpwatrous
requested review from
bgklein,
cRui861,
gingi and
paterasMSFT
as code owners
dpwatrous
force-pushed
the
dpwatrous/electron9
branch
from
ddace7e
to
a97e782
Compare
paterasMSFT
approved these changes
Jul 10, 2020
|
Looks like there's an issue with Karma and Electron 9 which is causing the tests to hang. I was able to reproduce it with minimal code. Opened an issue here |
Codecov Report
@@ Coverage Diff @@
## master #2195 +/- ##
==========================================
- Coverage 65.13% 65.13% -0.01%
==========================================
Files 899 899
Lines 25653 25654 +1
Branches 5090 5090
==========================================
Hits 16710 16710
- Misses 8943 8944 +1
Continue to review full report at Codecov.
|
dpwatrous
force-pushed
the
dpwatrous/electron9
branch
from
4e3e908
to
e2f3eb1
Compare
Removed devtron as it is unmaintained and has Electron 9 issues.
Window indices did not seem to be consistent across OSes. Switched to detect each window by URL instead.
This was causing Electron to hang after tests complete
dpwatrous
force-pushed
the
dpwatrous/electron9
branch
from
e2f3eb1
to
d0e226f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.