Add AGC certificates to CA-certificates when WEBSITES_USE_CLOUD_CERTS is set to true. #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CooperLink
requested review from
anirudhgarg,
vrdmr,
balag0,
pragnagopa,
ahmelsayed,
TsuyoshiUshio,
VpOfEngineering,
amamounelsayed and
Tonewall
as code owners
pragnagopa
reviewed
May 8, 2024
| @@ -3,15 +3,33 @@ | |||
| # Source and destination directories | |||
| source_dir="/var/ssl/root" | |||
| destination_dir="/usr/local/share/ca-certificates" | |||
| need_certificate_update=false | |||
|
|
|||
| if [[ "$WEBSITES_INCLUDE_CLOUD_CERTS" == "true" ]]; then | |||
There was a problem hiding this comment.
@CooperLink - is the Env var "$WEBSITES_INCLUDE_CLOUD_CERTS" expected to be set when running in AGC?
There was a problem hiding this comment.
This is going to roll out a mitigation for AGC customers. Such that they can set the flag to unblock. Any method of knowing which images these customers are using would likely require an Antares change
stevenernst131
approved these changes
May 8, 2024
pragnagopa
approved these changes
May 20, 2024
v-imohammad
pushed a commit
that referenced
this pull request
May 21, 2024
… is set to true. (#1077) * Update dotnet * Update with conditional * Update install_ca_certs for all --------- Co-authored-by: Cooper Link <cooperlink@microsoft.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validated that when a certificate is present in the supplied path and the env var is enabled., Linux Images copy the certificates and update their ca-certs
Releasing new Host versions.
V3 Release
V2 Release
PR information