Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[in-proc8] Fix IConfiguration mock behaviour #10102

Merged
merged 1 commit into from
May 2, 2024

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented May 2, 2024

Issue describing the changes in this PR

#10044

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Fix use of IConfiguration in unit tests by setting up the IConfiguration["SomeKey"] mock

@liliankasem liliankasem requested a review from a team as a code owner May 2, 2024 21:45
@liliankasem liliankasem merged commit a6fae9c into feature/in-proc8 May 2, 2024
2 checks passed
@liliankasem liliankasem deleted the liliankasem/testfix/configmoq branch May 2, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants