Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix artifact generation to support multi TFM #10107

Merged
merged 4 commits into from
May 3, 2024

Conversation

kshyju
Copy link
Member

@kshyju kshyju commented May 3, 2024

Addresses part of #10044

Fix artifact generation to support multi TFM.

Sample run: https://azfunc.visualstudio.com/Azure%20Functions/_build/results?buildId=165387&view=artifacts&pathAsName=false&type=publishedArtifacts

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@kshyju kshyju requested a review from a team as a code owner May 3, 2024 17:29
@kshyju kshyju requested review from jviau, brettsam and fabiocav May 3, 2024 17:30
@jviau
Copy link
Contributor

jviau commented May 3, 2024

I notice we are packing separate nuget artifacts for net6 and net8. This isn't really necessary as a nuget package can contain multiple TFMs with in (and the best match will be referenced during build).

Do we want to ship separate packages, or are we intended to ship 1?

@kshyju
Copy link
Member Author

kshyju commented May 3, 2024

I notice we are packing separate nuget artifacts for net6 and net8. This isn't really necessary as a nuget package can contain multiple TFMs with in (and the best match will be referenced during build).

Do we want to ship separate packages, or are we intended to ship 1?

Yea, that makes sense. I removed the redundant NuGet packages & also updated the nuget push step.

@kshyju kshyju merged commit 265a041 into feature/in-proc8 May 3, 2024
5 of 9 checks passed
@kshyju kshyju deleted the shkr/net8_artifacts_20240501 branch May 3, 2024 18:59
fabiocav pushed a commit that referenced this pull request May 7, 2024
Fix artifact generation to support multi TFM
fabiocav pushed a commit that referenced this pull request May 8, 2024
Fix artifact generation to support multi TFM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants