Updating assembly unification manifest and dependencies. #10110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiocav
commented
May 4, 2024
| @@ -34,10 +35,10 @@ public RuntimeAssembliesInfo(IEnvironment instance) | |||
| lock (_loadSyncRoot) | |||
| { | |||
| _relaxedUnification = FeatureFlags.IsEnabled(ScriptConstants.FeatureFlagRelaxedAssemblyUnification, _environment); | |||
|
|
|||
| string manifestName = _relaxedUnification.Value | |||
| var tfmversion = typeof(string).Assembly.GetName().Version.Major; | |||
There was a problem hiding this comment.
Will revisit this flow, but this will give us the resolution we need at the moment.
fabiocav
force-pushed
the
fabiocav/deps-asm-updt
branch
from
dca7581
to
53890c1
Compare
|
Assembly manifest diff for comparison: https://gist.github.com/fabiocav/9ce583f685f8bb6c37d631a95641c894/revisions?diff=split&w= |
fabiocav
added a commit
that referenced
this pull request
May 7, 2024
fabiocav
added a commit
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Part of #10044
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-procbranch to be included in Core Tools and non-Flex deployments.in-procbranch is not requiredrelease_notes.md