Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[.NET 8 in-proc] Multi targeting .NET 6 and .NET 8 #10118

Merged
merged 12 commits into from
May 8, 2024
Merged

[.NET 8 in-proc] Multi targeting .NET 6 and .NET 8 #10118

merged 12 commits into from
May 8, 2024

Conversation

fabiocav
Copy link
Member

@fabiocav fabiocav commented May 7, 2024 •
edited

Issue describing the changes in this PR

resolves #10044

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

jviau and others added 11 commits May 6, 2024 18:48
@jviau @fabiocav
[pack] Use dotnet common artifacts output (#9858)
3a4da04 
* Use dotnet common artifacts output

* Fix test paths

* Fix more tests

* Compress-Archive fix attempt

* Fix more tests

* Remove verbose log from build script

* Update build-extensions.ps1

* Remove release_* from esrp signing

* Force build

* Allow for packing via --pack

* Use powershell core --pack

* Force build --pack

* Fix pwsh --pack

* Upgrade back to .NET8

* Fix copy-paste error

* Fix Verify_DepsJsonChanges

* Undo SDK upgrade
@fabiocav
Multi-targeting .NET 6 and .NET 8
c2efcc8
@fabiocav
Fixing an issue with DryIcO service type validation
8e2f29d
@liliankasem @fabiocav
Fixing launch.json, IConfiguration mock behaviour and ProxyFunctionDe…
d7a9138 
…scriptorProviderTests
@kshyju @fabiocav
Fix artifact generation to support multi TFM (#10107)
6be4e84 
Fix artifact generation to support multi TFM
@liliankasem @fabiocav
[in-proc8] Update deps json test for multi-target (#10097)
4c2c9a7
@liliankasem @fabiocav
Remove TFM from common.props and update .csproj files (#10109)
6aaf024
@fabiocav
Updating assembly unification manifest and dependencies. (#10110)
bf7ffe0
@fabiocav
Temporary updates to metada generator to use new runtime assemblies m…
a84c444 
…anifests
@liliankasem @fabiocav
Update integration test path & build sln for tests, HostProcessLaunch…
e5197db 
…er testpath to debug
@jviau @fabiocav
Update CSharpPrecompiledTestProjects to func v4 (#10095)
eabeb7f
@fabiocav fabiocav requested review from brettsam, mathewc and a team as code owners May 7, 2024 02:06
@fabiocav fabiocav merged commit bf23160 into in-proc May 8, 2024
6 of 8 checks passed
@fabiocav fabiocav deleted the fabiocav/in-proc8-clean branch May 8, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jviau jviau jviau left review comments

@brettsam brettsam brettsam approved these changes

@liliankasem liliankasem liliankasem approved these changes

@mathewc mathewc Awaiting requested review from mathewc mathewc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fabiocav @brettsam @liliankasem @jviau @kshyju