-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for container app connected environment #10158
Open
ishank12
wants to merge
5
commits into
Azure:dev
Choose a base branch
from
ishank12:ishank/supportConnectedEnvironment
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+64
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandgmenon
approved these changes
May 14, 2024
AmeyaRele
reviewed
May 16, 2024
mathewc
reviewed
May 20, 2024
Also, you need to fill out the PR template check boxes. E.g. does this need to be backported to inproc, etc. |
mathewc
approved these changes
May 20, 2024
anandgmenon
approved these changes
May 21, 2024
anandgmenon
approved these changes
May 22, 2024
AmeyaRele
approved these changes
May 22, 2024
@ishank12 Is this PR waiting on something before it can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Sync trigger api works when host is running on ContainerApp ManagedEnvironment.
However logic apps is running on ARC that has the concept of ConnectedEnvironment.
So adding the support of sync trigger for ConnectedEnvironment as well same as Managed Environment.
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
Additional PR information