-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SiteExtension.proj to replace build-extension.ps1 #10168
Open
jviau
wants to merge
30
commits into
dev
Choose a base branch
from
jviau/eng/site-proj
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyju
reviewed
May 16, 2024
kshyju
reviewed
May 16, 2024
test/WebJobs.Script.Tests.Integration/WebJobs.Script.Tests.Integration.csproj
Show resolved
Hide resolved
kshyju
reviewed
May 16, 2024
src/WebJobs.Script.SiteExtension/WebJobs.Script.SiteExtension.proj
Outdated
Show resolved
Hide resolved
kshyju
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
resolves #issue_for_this_pr
Pull request checklist
IMPORTANT: Currently, changes must be backported to the
in-proc
branch to be included in Core Tools and non-Flex deployments.in-proc
branch is not requiredrelease_notes.md
Additional information
This PR introduces a new project
WebHost.Script.SiteExtension
, which is a replacement forbuild-extension.ps1
. This project can be used viadotnet
CLI to restore, build, and publish all the artifacts needed for the Antares site extension. Note that this project has support for multi-targeting, but only targets a single TFM. This is in preparation for porting toin-proc
branch to keep the diff minimal between the two.Other Changes
update-hostreferences.ps1
, this is no longer used anywhereworkers.props
file. Left python out due to code owners, but ideally python will be moved there as well.ZipPublish.targets
.RuntimeIdentifiers
added toWebHost.csproj
. Having this set of identifiers listed improves the restore task (otherwise each time you want to use a different runtime, you have to re-restore).