Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1ES] Fix Official and PR 1es builds #10176

Merged
merged 5 commits into from
May 18, 2024
Merged

[1ES] Fix Official and PR 1es builds #10176

merged 5 commits into from
May 18, 2024

Conversation

jviau
Copy link
Contributor

@jviau jviau commented May 16, 2024

Issue describing the changes in this PR

resolves #issue_for_this_pr

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR -- TODO
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Fixes the following CI and PR issues:

  • Invalid stage name for 1ES PR build
  • Removes unneeded NugetAuthenticate steps
  • Removes uses of $(minorVersionPrefix)

@jviau jviau requested review from fabiocav, brettsam and a team as code owners May 16, 2024 23:49
@jviau jviau added the 1es 1 engineering system label May 16, 2024
@jviau jviau changed the title Jviau/eng/fix pr stage [1ES] Fix Official and PR 1es builds May 16, 2024
@jviau jviau merged commit a7ba651 into dev May 18, 2024
10 checks passed
@jviau jviau deleted the jviau/eng/fix-pr-stage branch May 18, 2024 00:27
jviau added a commit that referenced this pull request May 20, 2024
* Fix stage name

* Fix 1es pr and official build issues

* Update integration-tests triggers

* Extract build.yml variables

* Undo template path change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1es 1 engineering system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants