Fixed issue with functions in nested classes not being found #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
woojamon
changed the title
|
Looks like the build failed due to some issue with trying to access an azure storage account. Unfortunately I'm not sure if I can fix that. Tests passed though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #401, but also fixes an issue I was having with defining functions inside nested classes, where the runtime wouldn't discover them.
I couldn't run most of the tests in the solution for some reason, but I was able to run the relevant
NestedFunctionMethodsAreExportedandFunctionMethodsAreExportedtests to verify new functionality according to red/green testing.The only difference in the tests is the
NestedFunctionsClassin test/Microsoft.NET.Sdk.Functions.Generator.Tests/FunctionJsonConverterTests.cs, line: 112