Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appInsights mapping for spain central, and qatarcentral #14023

Merged

Conversation

iyangchen
Copy link

PR Checklist

Check these items before submitting a PR...

Contribution Guide

Best Practice Guide

  • - Please check this box once you've submitted the PR if you've read through the Contribution Guide and best practices checklist.

Changelog

Added AppInsights mapping for new region Spain Central. Also added back the Qatar Central mapping since it got overwritten by previous auto merging commits, it was introduced here #13442

@azure-quickstarts azure-quickstarts added remove azuredeploy.json bicep sample, remove json from PR bicep warnings labels May 10, 2024
@azure-quickstarts
Copy link
Collaborator

@Blackmist - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

Copy link
Contributor

@alex-frankel alex-frankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a bicep file in this directory which is the source of truth for this template. Please edit the bicep file instead. The CI pipeline will take care of generating the new ARM Template.

@iyangchen iyangchen force-pushed the iyangchen/spaincentral-region-buildout branch from 58614b0 to 84230ea Compare May 10, 2024 20:13
@azure-quickstarts azure-quickstarts removed the remove azuredeploy.json bicep sample, remove json from PR label May 10, 2024
@azure-quickstarts
Copy link
Collaborator

@Blackmist - check this PR for updates that may be needed to documentation that references this sample. [This is an automated message. You are receiving it because you are listed as the docOwner in metadata.json.]

@alex-frankel alex-frankel merged commit b247aa7 into Azure:master May 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants