New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tags] Add "tagsoperationresults" resource type to "Microsoft.Resources" #28999
Open
Grayer123
wants to merge
1
commit into
Azure:main
Choose a base branch
from
Grayer123:ran/tagsoperationresults
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Swagger Validation Report
|
Compared specs (v0.10.8) | new version | base version |
---|---|---|
resources.json | 2022-09-01(ece22ca) | 2022-09-01(main) |
resources.json | 2023-07-01(ece22ca) | 2023-07-01(main) |
Rule | Message |
---|---|
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Resources/stable/2022-09-01/resources.json#L3843:5 |
1038 - AddedPath |
The new version is adding a path that was not found in the old version. New: Microsoft.Resources/stable/2023-07-01/resources.json#L3849:5 |
️️✔️
Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️
CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌
LintDiff: 2 Errors, 4 Warnings failed [Detail]
Compared specs (v2.2.2) | new version | base version |
---|---|---|
package-resources-2023-07 | package-resources-2023-07(ece22ca) | package-resources-2023-07(main) |
package-resources-2022-09 | package-resources-2022-09(ece22ca) | package-resources-2022-09(main) |
[must fix]The following errors/warnings are introduced by current PR:
Rule | Message | Related RPC [For API reviewers] |
---|---|---|
GetOperationMustNotBeLongRunning |
The GET operation cannot be long running. It must not have the x-ms-long-running-operation and x-ms-long-running-operation-options properties defined.Location: Microsoft.Resources/stable/2022-09-01/resources.json#L3882 |
RPC-Get-V1-14 |
GetOperationMustNotBeLongRunning |
The GET operation cannot be long running. It must not have the x-ms-long-running-operation and x-ms-long-running-operation-options properties defined.Location: Microsoft.Resources/stable/2023-07-01/resources.json#L3888 |
RPC-Get-V1-14 |
'GET' operation 'Tags_OperationResult' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L3848 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TagsModel'. Consider using the plural form of 'Tags' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L3848 |
||
'GET' operation 'Tags_OperationResult' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L3854 |
||
OperationId has a noun that conflicts with one of the model names in definitions section. The model name will be disambiguated to 'TagsModel'. Consider using the plural form of 'Tags' to avoid this. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Resources/stable/2023-07-01/resources.json#L3854 |
The following errors/warnings exist before current PR submission:
Only 30 items are listed, please refer to log for more details.
Rule | Message |
---|---|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L254 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L562 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L938 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Predict template changes at management group scope Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1045 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1326 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1538 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1581 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1624 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Create a deployment that will deploy a templateSpec with the given resourceId Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1672 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1696 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1741 |
|
A LRO Post operation with return schema must have 'x-ms-long-running-operation-options' extension enabled. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1773 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1783 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1845 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1920 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L1964 |
|
Since operation response has model definition in array type, it should be of the form '_list'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2089 |
|
Based on the response model schema, operation 'Providers_ProviderPermissions' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2089 |
|
'GET' operation 'Providers_ProviderPermissions' should use method name 'Get' or Method name start with 'List'. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2093 |
|
Based on the response model schema, operation 'ProviderResourceTypes_List' might be pageable. Consider adding the x-ms-pageable extension. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2313 |
|
Do not have duplicate name of x-ms-example, make sure every x-ms-example name unique. Duplicate x-ms-example: Get provider resource types. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2355 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2418 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2485 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2529 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2584 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2639 |
|
Not using the common-types defined parameter 'resourceGroupName'. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2679 |
|
Use the latest version v5 of types.json. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2729 |
|
Use the latest version v5 of types.json. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2732 |
|
Use the latest version v5 of types.json. Location: Microsoft.Resources/stable/2022-09-01/resources.json#L2735 |
️️✔️
Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️
SwaggerAPIView succeeded [Detail] [Expand]
️️✔️
TypeSpecAPIView succeeded [Detail] [Expand]
️❌
ModelValidation: 10 Errors, 0 Warnings failed [Detail]
️️✔️
SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️
PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️❌
SpellCheck: 2 Errors, 0 Warnings failed [Detail]
Rule | Message |
---|---|
HowToFix |
Unknown word (tagsoperationresults), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.Resources/stable/2022-09-01/resources.json#L3843:38 |
HowToFix |
Unknown word (tagsoperationresults), please fix the error. See https://aka.ms/ci-fix#spell-check path: Microsoft.Resources/stable/2023-07-01/resources.json#L3849:38 |
️️✔️
Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️
PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️
Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
This was referenced May 7, 2024
Grayer123
changed the title
Add tagsoperationresults to microsoft.resources.
[Tags] Add "tagsoperationresults" resource type to "Microsoft.Resources"
May 7, 2024
This was referenced May 7, 2024
AzureRestAPISpecReview
added
ARMReview
NotReadyForARMReview
resource-manager
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
labels
May 7, 2024
This was referenced May 7, 2024
This was referenced May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARMReview
BreakingChange-JavaScript-Sdk
NotReadyForARMReview
resource-manager
VersioningReviewRequired
<valid label in PR review process>add this label when versioning review is required
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add "tagsoperationresults" resource type to "microsoft.resources" for api-version: "2022-09-01" and "2023-07-01".