Upgrade test proxy, broken tests run only in live and recording modes

[azp skip]
Azure · May 9, 2024 · c99558a · c99558a
1 parent 73894f3
commit c99558a
Show file tree

Hide file tree

Showing 259 changed files with 992 additions and 5 deletions.
diff --git a/eng/target_proxy_version.txt b/eng/target_proxy_version.txt
@@ -1 +1 @@
-1.0.0-dev.20240410.1
+1.0.0-dev.20240508.1
diff --git a/sdk/ai/azopenai/client_audio_test.go b/sdk/ai/azopenai/client_audio_test.go
@@ -21,6 +21,9 @@ import (
 )
 
 func TestClient_GetAudioTranscription(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	testFn := func(t *testing.T, epm endpointWithModel) {
 		client := newTestClient(t, epm.Endpoint)
 		model := epm.Model
@@ -136,6 +139,9 @@ func TestClient_GetAudioTranscription(t *testing.T) {
 }
 
 func TestClient_GetAudioTranslation(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	testFn := func(t *testing.T, epm endpointWithModel) {
 		client := newTestClient(t, epm.Endpoint)
 		model := epm.Model
@@ -252,7 +258,7 @@ func TestClient_GetAudioTranslation(t *testing.T) {
 
 func TestClient_GetAudioSpeech(t *testing.T) {
 	if recording.GetRecordMode() == recording.PlaybackMode {
-		t.Skip("TODO: sanitization break: needs to be looked at")
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
 	}
 
 	client := newTestClient(t, openAI.Speech.Endpoint)

diff --git a/sdk/ai/azopenai/client_functions_test.go b/sdk/ai/azopenai/client_functions_test.go
@@ -11,6 +11,7 @@ import (
 
 	"github.com/Azure/azure-sdk-for-go/sdk/ai/azopenai"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
+	"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
 	"github.com/stretchr/testify/require"
 )
 
@@ -27,6 +28,9 @@ type ParamProperty struct {
 }
 
 func TestGetChatCompletions_usingFunctions(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	// https://platform.openai.com/docs/guides/gpt/function-calling
 
 	testFn := func(t *testing.T, chatClient *azopenai.Client, deploymentName string, toolChoice *azopenai.ChatCompletionsToolChoice) {
@@ -127,6 +131,9 @@ func TestGetChatCompletions_usingFunctions(t *testing.T) {
 }
 
 func TestGetChatCompletions_usingFunctions_legacy(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	testFn := func(t *testing.T, epm endpointWithModel) {
 		client := newTestClient(t, epm.Endpoint)
 

diff --git a/sdk/ai/azopenaiassistants/client_test.go b/sdk/ai/azopenaiassistants/client_test.go
@@ -123,6 +123,9 @@ func TestAssistantCreationAndListing(t *testing.T) {
 }
 
 func TestAssistantMessages(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	testFn := func(t *testing.T, azure bool) {
 		client := newClient(t, newClientArgs{
 			Azure: azure,
@@ -196,8 +199,8 @@ func TestAssistantMessages(t *testing.T) {
 }
 
 func skipRecordingsCantMatchRoutesTestHack(t *testing.T) {
-	if recording.GetRecordMode() != recording.LiveMode {
-		t.Skip("skipping due to issue where recordings never match. Issue #22839")
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("skipping due to issue where recordings never match. Issue #22839. Also #22869")
 	}
 }
 
@@ -655,6 +658,9 @@ func TestNewListRunStepsPager(t *testing.T) {
 }
 
 func TestFiles(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	testFn := func(t *testing.T, azure bool) {
 		client := newClient(t, newClientArgs{
 			Azure: azure,

diff --git a/sdk/containers/azcontainerregistry/authentication_policy_test.go b/sdk/containers/azcontainerregistry/authentication_policy_test.go
@@ -17,6 +17,7 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/streaming"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
 	"github.com/Azure/azure-sdk-for-go/sdk/internal/mock"
+	"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
 	"github.com/Azure/azure-sdk-for-go/sdk/internal/temporal"
 	"github.com/stretchr/testify/require"
 	"net/http"
@@ -126,6 +127,9 @@ func Test_findServiceAndScope(t *testing.T) {
 }
 
 func Test_authenticationPolicy_getAccessToken_live(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	if reflect.ValueOf(options.Cloud).IsZero() {

diff --git a/sdk/containers/azcontainerregistry/blob_client_test.go b/sdk/containers/azcontainerregistry/blob_client_test.go
@@ -15,6 +15,7 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/streaming"
 	"github.com/Azure/azure-sdk-for-go/sdk/internal/mock"
+	"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
 	"github.com/stretchr/testify/require"
 	"io"
 	"net/http"
@@ -26,6 +27,9 @@ import (
 const alpineBlobDigest = "sha256:042a816809aac8d0f7d7cacac7965782ee2ecac3f21bcf9f24b1de1a7387b769"
 
 func TestBlobClient_CancelUpload(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -48,6 +52,9 @@ func TestBlobClient_CancelUpload_fail(t *testing.T) {
 }
 
 func TestBlobClient_CheckBlobExists(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -79,6 +86,9 @@ func TestBlobClient_CheckBlobExists_empty(t *testing.T) {
 }
 
 func TestBlobClient_CheckChunkExists(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -110,6 +120,9 @@ func TestBlobClient_CheckChunkExists_empty(t *testing.T) {
 }
 
 func TestBlobClient_completeUpload_wrongDigest(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -128,6 +141,9 @@ func TestBlobClient_completeUpload_wrongDigest(t *testing.T) {
 }
 
 func TestBlobClient_DeleteBlob(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -158,6 +174,9 @@ func TestBlobClient_DeleteBlob_empty(t *testing.T) {
 }
 
 func TestBlobClient_GetBlob(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -213,6 +232,9 @@ func TestBlobClient_GetBlob_empty(t *testing.T) {
 }
 
 func TestBlobClient_GetChunk(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -262,6 +284,9 @@ func TestBlobClient_GetChunk_empty(t *testing.T) {
 }
 
 func TestBlobClient_GetUploadStatus(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -287,6 +312,9 @@ func TestBlobClient_GetUploadStatus_fail(t *testing.T) {
 }
 
 func TestBlobClient_MountBlob(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -316,6 +344,9 @@ func TestBlobClient_MountBlob_empty(t *testing.T) {
 }
 
 func TestBlobClient_StartUpload(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()

diff --git a/sdk/containers/azcontainerregistry/blob_custom_client_test.go b/sdk/containers/azcontainerregistry/blob_custom_client_test.go
@@ -16,13 +16,17 @@ import (
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/runtime"
 	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
 	"github.com/Azure/azure-sdk-for-go/sdk/internal/mock"
+	"github.com/Azure/azure-sdk-for-go/sdk/internal/recording"
 	"github.com/stretchr/testify/require"
 	"io"
 	"net/http"
 	"testing"
 )
 
 func TestBlobClient_CompleteUpload(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -43,6 +47,9 @@ func TestBlobClient_CompleteUpload(t *testing.T) {
 }
 
 func TestBlobClient_UploadChunk(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -63,6 +70,9 @@ func TestBlobClient_UploadChunk(t *testing.T) {
 }
 
 func TestBlobClient_CompleteUpload_uploadByChunk(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()
@@ -112,6 +122,9 @@ func TestNewBlobClient(t *testing.T) {
 }
 
 func TestBlobClient_CompleteUpload_uploadByChunkFailOver(t *testing.T) {
+	if recording.GetRecordMode() == recording.PlaybackMode {
+		t.Skip("https://github.com/Azure/azure-sdk-for-go/issues/22869")
+	}
 	startRecording(t)
 	endpoint, cred, options := getEndpointCredAndClientOptions(t)
 	ctx := context.Background()