Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit stable auto-instrumented otel metrics #39960

Merged
merged 9 commits into from
May 9, 2024
Merged

Emit stable auto-instrumented otel metrics #39960

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8ac847a
Update otel metrics logic
heyams Apr 30, 2024
9856397
add runtime metrics
harsimar May 2, 2024
645d83f
adding a few metrics I forgot
harsimar May 2, 2024
7351134
small correction
harsimar May 2, 2024
bc84952
Update
heyams May 6, 2024
e2b6254
Merge branch 'heya/otel-metrics' of https://github.com/heyams/azure-s…
heyams May 6, 2024
7b99c6e
Fix
heyams May 6, 2024
e39e7f2
Update
heyams May 7, 2024
5d8b508
Delete pre-stable metrics
heyams May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 19 additions & 14 deletions ...c/main/java/com/azure/monitor/opentelemetry/exporter/implementation/MetricDataMapper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,22 @@ public class MetricDataMapper {

private static final ClientLogger logger = new ClientLogger(MetricDataMapper.class);

private static final Set<String> OTEL_UNSTABLE_METRICS_TO_EXCLUDE = new HashSet<>();
private static final String OTEL_INSTRUMENTATION_NAME_PREFIX = "io.opentelemetry";
private static final Set<String> OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES = new HashSet<>(4);
private static final List<String> EXCLUDED_METRIC_NAMES = new ArrayList<>();
public static final AttributeKey<String> APPLICATIONINSIGHTS_INTERNAL_METRIC_NAME = AttributeKey.stringKey("applicationinsights.internal.metric_name");

private final BiConsumer<AbstractTelemetryBuilder, Resource> telemetryInitializer;
private final boolean captureHttpServer4xxAsError;

static {
EXCLUDED_METRIC_NAMES.add("http.server.active_requests"); // Servlet
EXCLUDED_METRIC_NAMES.add("http.server.response.size");
EXCLUDED_METRIC_NAMES.add("http.client.response.size");
// HTTP unstable metrics to be excluded via Otel auto instrumentation
OTEL_UNSTABLE_METRICS_TO_EXCLUDE.add("rpc.client.duration");
OTEL_UNSTABLE_METRICS_TO_EXCLUDE.add("rpc.server.duration");

// Application Insights pre-aggregated standard metrics
heyams marked this conversation as resolved.
Show resolved Hide resolved
OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES.add("http.server.request.duration");
OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES.add("http.client.request.duration");
OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES.add("http.server.duration"); // pre-stable HTTP semconv
OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES.add("http.client.duration"); // pre-stable HTTP semconv
OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES.add("rpc.client.duration");
OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES.add("rpc.server.duration");
}
Expand All @@ -73,10 +73,6 @@ public MetricDataMapper(
}

public void map(MetricData metricData, Consumer<TelemetryItem> consumer) {
if (EXCLUDED_METRIC_NAMES.contains(metricData.getName())) {
return;
}

MetricDataType type = metricData.getType();
if (type == DOUBLE_SUM
|| type == DOUBLE_GAUGE
Expand All @@ -85,11 +81,20 @@ public void map(MetricData metricData, Consumer<TelemetryItem> consumer) {
|| type == HISTOGRAM) {
boolean isPreAggregatedStandardMetric =
OTEL_PRE_AGGREGATED_STANDARD_METRIC_NAMES.contains(metricData.getName());
List<TelemetryItem> telemetryItemList =
convertOtelMetricToAzureMonitorMetric(metricData, isPreAggregatedStandardMetric);
for (TelemetryItem telemetryItem : telemetryItemList) {
consumer.accept(telemetryItem);
if (isPreAggregatedStandardMetric) {
List<TelemetryItem> preAggregatedStandardMetrics =
convertOtelMetricToAzureMonitorMetric(metricData, true);
preAggregatedStandardMetrics.forEach(consumer::accept);
}

// DO NOT emit unstable metrics from the OpenTelemetry auto instrumentation libraries
// custom metrics are always emitted
if (OTEL_UNSTABLE_METRICS_TO_EXCLUDE.contains(metricData.getName())
&& metricData.getInstrumentationScopeInfo().getName().startsWith(OTEL_INSTRUMENTATION_NAME_PREFIX)) {
return;
}
List<TelemetryItem> stableOtelMetrics = convertOtelMetricToAzureMonitorMetric(metricData, false);
stableOtelMetrics.forEach(consumer::accept);
} else {
logger.warning("metric data type {} is not supported yet.", metricData.getType());
}
Expand Down